CVS log for JSOC/proj/sharp/apps/sw_functions.c

(logo)

Help

(back) Up to [Development] / JSOC / proj / sharp / apps

Request diff between arbitrary revisions


Default branch: MAIN
Bookmark a link to: HEAD / (download)
Current tag: Ver_8-7

Revision 1.33 / (view) - annotate - [select for diffs] , Fri Jan 23 01:18:13 2015 UTC (7 years, 10 months ago) by mbobra
Branch: MAIN
CVS Tags: Ver_8-7
Changes since 1.32: +28 -23 lines
Diff to previous 1.32
changed the numerical derivative. here is a description of the problem that i fixed:

In computeJz(), the newly malloc'd jz array has its interior
points filled with values but its boundary points are left
alone:

    for (i = 1; i <= nx-2; i++)
    {
        for (j = 1; j <= ny-2; j++)
        {
            // calculate jz at all points
            ...

In all subsequent functions the array jz is used whole, including
the uninitialized border.

I ran your test case in the debugger.  On n02, jz was 0 on the
border; on solar3, I got wild values

(gdb) p jz[0]
$16 = 1.37765386e+10
(gdb) p jz[1]
$17 = 1.35754556e-19
(gdb) p jz[2]
$18 = 1.35631939e-19

If the code relies on the border being 0, then it was pure luck
that it ran correctly on x86_64.

This form allows you to request diffs between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.

Diffs between and
Type of Diff should be a

View only Branch:
Sort log by:

Karen Tian
Powered by
ViewCVS 0.9.4